Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc build #863

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Fix doc build #863

merged 2 commits into from
Jul 25, 2022

Conversation

oleksandr-pavlyk
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk commented Jul 25, 2022

With release of Sphinx 5.1.0 the dpctl documentation build started failing due to sphinx-doc/sphinx#10701 with an exception in sphinx.

The exception is tripped by missing or empty docstrings for property class attributes as pointed out by @yaricoptic.

Update in Sphinx also revealed two typos in Doxygen annotations which this PR also fixed.

  • Have you provided a meaningful PR description?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?

Due to sphinx-doc/sphinx#10701 documentation build of dpctl started failing
with release of Sphinx 5.1.0.

The exception raised is triggered by missing docstrings for property class
attributes.

This change adds such docstrings and now local documentation build goes through
as expected.
@github-actions
Copy link

@coveralls
Copy link
Collaborator

Coverage Status

Coverage decreased (-0.02%) to 81.589% when pulling 3769349 on fix-doc-build into f45710f on master.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 594351f into master Jul 25, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-doc-build branch July 25, 2022 13:24
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants