Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NumPy argument support for dpex kernels #864

Closed
7 tasks
diptorupd opened this issue Jan 10, 2023 · 0 comments · Fixed by #1049
Closed
7 tasks

Remove NumPy argument support for dpex kernels #864

diptorupd opened this issue Jan 10, 2023 · 0 comments · Fixed by #1049
Assignees
@mingjie-intel

Comments

@diptorupd
Copy link
Contributor

diptorupd commented Jan 10, 2023 •
edited by mingjie-intel
Loading

We will stop supporting NumPy arrays as arguments to kernel. The following API changes need to be made:

  • Remove array_access_specifiers from JitKernel init
  • Remove get_ordered_arg_access_types
  • Simplify JitKernel._determine_kernel_launch_queue
  • Remove the special case for calling npytypes_array_to_dpex_array inside target.TypingContext. Instead if a NumPy array argument is detected raise an exception.
  • Remove access types from Packer
  • Remove support for array from Packer._unpack_arguments
  • Remove _pack_array from Packer and sycl_queue in init
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mingjie-intel mingjie-intel

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@diptorupd @mingjie-intel