Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/remove numpy array kernelargs #1049

Merged
merged 7 commits into from
May 22, 2023
Merged

Feature/remove numpy array kernelargs #1049

merged 7 commits into from
May 22, 2023

Conversation

diptorupd
Copy link
Contributor

@diptorupd diptorupd commented May 20, 2023 •
edited
Loading

  • Have you provided a meaningful PR description?

Removes the support for NumPy arrays as kernel arguments that was deprecated in the 0.20 release.

  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

Fixes #864

Diptorup Deb added 7 commits May 20, 2023 00:46
Remove NumPy based test cases that are no longer supported.
6eae62a
Remove access specifier keyword from kernel decorator.
a89649a
Remove NumPy ndarray-specific arg pack/unpack.
dcc82a9
Fix typos.
8946718
Remove type support for numpy arrays in kernels.
21d4085
Simplification of exec. queue derivation.
86d5d4e 
    - The removal of support for NumPy args in kernels helps
      simplify the logic for execution queue derivation.
    - The ComputeFollowsDataInferenceError was renamed to
      ExecutionQueueInferenceError, and the old
      ExecutionQueueInferenceError was removed.
Test case to verify NumPy args are no longer supported.
218df52
@diptorupd diptorupd requested a review from mingjie-intel May 20, 2023 07:05
@diptorupd diptorupd mentioned this pull request May 20, 2023
Closed
7 tasks
Base automatically changed from feature/support_numba057 to main May 22, 2023 19:07
@diptorupd diptorupd mentioned this pull request May 22, 2023
Closed
@diptorupd diptorupd merged commit e7a4420 into main May 22, 2023
@diptorupd diptorupd deleted the feature/remove_numpy_array_kernelargs branch May 22, 2023 20:40
github-actions bot added a commit that referenced this pull request May 22, 2023
@github-actions
Merge pull request #1049 from IntelPython/feature/remove_numpy_array_…
f63b140 
…kernelargs

Feature/remove numpy array kernelargs e7a4420
github-actions bot pushed a commit that referenced this pull request May 22, 2023
@diptorupd
Merge pull request #1049 from IntelPython/feature/remove_numpy_array_…
a230363 
…kernelargs

Feature/remove numpy array kernelargs e7a4420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingjie-intel mingjie-intel Awaiting requested review from mingjie-intel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove NumPy argument support for dpex kernels
1 participant
@diptorupd