Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace parent package for cached_property import #1003

Merged
merged 1 commit into from
Apr 15, 2023
Merged

Replace parent package for cached_property import #1003

merged 1 commit into from
Apr 15, 2023

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Apr 14, 2023 •
edited
Loading

For some reason it is no longer available via numba.core.utils import. Anyway, it looks like clean up change.
#1000

UPD: there are few places to face similar issue.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa self-assigned this Apr 14, 2023
@ZzEeKkAa ZzEeKkAa marked this pull request as draft April 14, 2023 22:37
@ZzEeKkAa ZzEeKkAa changed the title Replace parent package for cached_property import WIP: Replace parent package for cached_property import Apr 14, 2023
@ZzEeKkAa ZzEeKkAa force-pushed the fix/cached_property_import branch from dc593a4 to 0cc6881 Compare April 14, 2023 22:44
@ZzEeKkAa ZzEeKkAa changed the title WIP: Replace parent package for cached_property import Replace parent package for cached_property import Apr 14, 2023
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review April 14, 2023 22:45
diptorupd
diptorupd approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@diptorupd diptorupd force-pushed the fix/cached_property_import branch from 0cc6881 to 8ce0b64 Compare April 15, 2023 01:52
@diptorupd diptorupd merged commit dd11099 into main Apr 15, 2023
@diptorupd diptorupd deleted the fix/cached_property_import branch April 15, 2023 02:26
github-actions bot added a commit that referenced this pull request Apr 15, 2023
@github-actions
Merge pull request #1003 from IntelPython/fix/cached_property_import
ef8b42e 
Replace parent package for cached_property import dd11099
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

@mingjie-intel mingjie-intel Awaiting requested review from mingjie-intel

Assignees

@ZzEeKkAa ZzEeKkAa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZzEeKkAa @diptorupd