Making test_atomic_op testcase CFD compliant #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adarshyoga
force-pushed
the
fix/atomic_tests
branch
from
8ac2977 to
56b8869
Compare
adarshyoga
changed the title
diptorupd
force-pushed
the
fix/atomic_tests
branch
from
56b8869 to
aba4385
Compare
|
Merging based on public CI. |
github-actions bot
added a commit
that referenced
this pull request
Apr 22, 2023
Making test_atomic_op testcase CFD compliant 1f19e4e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the necessary changes to make test_atomic_op testcase follow "Compute Follows Data" semantics.
The input numpy ndarray declaration is changed to dpnp array.
All uses of dpctl.device_context has been removed. Filter strings are now passed directly to dpnp array allocation.
Kernel invocations now use dpex.Range classes for specifying global and local size.
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Fixes #986. Tested on 4th gen Xeon. Tests run on CPU with OpenCL backend and on GPU with level zero