Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign numba-dpex test suite #1018

Merged
merged 21 commits into from
Apr 28, 2023
Merged

Redesign numba-dpex test suite #1018

merged 21 commits into from
Apr 28, 2023

Conversation

diptorupd
Copy link
Contributor

@diptorupd diptorupd commented Apr 24, 2023 •
edited
Loading

  • Have you provided a meaningful PR description?

The PR is to partly address #883.

  • All kernel API and dpjit unit tests will follow the new compute follows data programming model.
  • All njit tests to be removed.
  • Duplicate and redundant test cases to be removed.
  • Test cases to be reorganized into sub-modules.
  • Possible improvements to existing unit tests.
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@diptorupd diptorupd force-pushed the redesign/test_suite branch from b74b3cc to a036e4e Compare April 24, 2023 21:08
@diptorupd diptorupd changed the title Redesign numba-dpex Redesign numba-dpex test suite Apr 24, 2023
@diptorupd diptorupd force-pushed the redesign/test_suite branch from 0cf611b to 3abfe12 Compare April 25, 2023 02:16
Diptorup Deb added 5 commits April 24, 2023 22:07
Remove test for deprecated feature.
97bfdb4
Fix test_arg_types.py
2f458d6
Fixes the private memory allocation test case.
e3c533b 
    - Test case now uses dpnp arrays and compute follows data
    - The previous test case was not actually testing private
      memory allocation as the code was being optimized out.
      The modified test case makes sure private memory is actually
      allocated.
Minor typo fixes in comments.
341951b
Fix and improve test_print.py
806ef50
@diptorupd diptorupd force-pushed the redesign/test_suite branch from 81dec55 to 59f7679 Compare April 25, 2023 21:12
@diptorupd diptorupd force-pushed the redesign/test_suite branch from 8821ee6 to 5655ab7 Compare April 26, 2023 01:48
@diptorupd
Copy link
Contributor Author

Merging the initial tranche of changes based on public CI.

@diptorupd diptorupd merged commit 094f852 into main Apr 28, 2023
@diptorupd diptorupd deleted the redesign/test_suite branch April 28, 2023 02:14
github-actions bot added a commit that referenced this pull request Apr 28, 2023
@github-actions
Merge pull request #1018 from IntelPython/redesign/test_suite
55b56b6 
Redesign numba-dpex test suite 094f852
@diptorupd diptorupd mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingjie-intel mingjie-intel Awaiting requested review from mingjie-intel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@diptorupd