Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed like arg in dpnp empty, zeros and ones overload. #1043

Merged
merged 1 commit into from
May 17, 2023
Merged

Removed like arg in dpnp empty, zeros and ones overload. #1043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions numba_dpex/dpnp_iface/_intrinsic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ def impl_dpnp_empty(
ty_shape,
ty_dtype,
ty_order,
# ty_like, # see issue https://github.com/IntelPython/numba-dpex/issues/998
ty_device,
ty_usm_type,
ty_sycl_queue,
Expand All @@ -145,7 +144,6 @@ def impl_dpnp_empty(
dtype.
ty_order (numba.core.types.misc.UnicodeType): UnicodeType
from numba for strings.
ty_like (numba.core.types.npytypes.Array): Numba type for array.
ty_device (numba.core.types.misc.UnicodeType): UnicodeType
from numba for strings.
ty_usm_type (numba.core.types.misc.UnicodeType): UnicodeType
Expand All @@ -165,7 +163,6 @@ def impl_dpnp_empty(
ty_shape,
ty_dtype,
ty_order,
# ty_like, # see issue https://github.com/IntelPython/numba-dpex/issues/998
ty_device,
ty_usm_type,
ty_sycl_queue,
Expand All @@ -185,7 +182,6 @@ def impl_dpnp_zeros(
ty_shape,
ty_dtype,
ty_order,
ty_like,
ty_device,
ty_usm_type,
ty_sycl_queue,
Expand All @@ -203,7 +199,6 @@ def impl_dpnp_zeros(
dtype.
ty_order (numba.core.types.misc.UnicodeType): UnicodeType
from numba for strings.
ty_like (numba.core.types.npytypes.Array): Numba type for array.
ty_device (numba.core.types.misc.UnicodeType): UnicodeType
from numba for strings.
ty_usm_type (numba.core.types.misc.UnicodeType): UnicodeType
Expand All @@ -223,7 +218,6 @@ def impl_dpnp_zeros(
ty_shape,
ty_dtype,
ty_order,
ty_like,
ty_device,
ty_usm_type,
ty_sycl_queue,
Expand All @@ -245,7 +239,6 @@ def impl_dpnp_ones(
ty_shape,
ty_dtype,
ty_order,
ty_like,
ty_device,
ty_usm_type,
ty_sycl_queue,
Expand All @@ -263,7 +256,6 @@ def impl_dpnp_ones(
dtype.
ty_order (numba.core.types.misc.UnicodeType): UnicodeType
from numba for strings.
ty_like (numba.core.types.npytypes.Array): Numba type for array.
ty_device (numba.core.types.misc.UnicodeType): UnicodeType
from numba for strings.
ty_usm_type (numba.core.types.misc.UnicodeType): UnicodeType
Expand All @@ -283,7 +275,6 @@ def impl_dpnp_ones(
ty_shape,
ty_dtype,
ty_order,
ty_like,
ty_device,
ty_usm_type,
ty_sycl_queue,
Expand Down
28 changes: 0 additions & 28 deletions numba_dpex/dpnp_iface/arrayobj.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,8 +210,6 @@ def ol_dpnp_empty(
shape,
dtype=None,
order="C",
# like=None, # this gets lost when dpnp.empty() is called outside dpjit,
# see issue https://github.com/IntelPython/numba-dpex/issues/998
device=None,
usm_type="device",
sycl_queue=None,
Expand All @@ -229,12 +227,6 @@ def ol_dpnp_empty(
Default: None.
order (str, optional): memory layout for the array "C" or "F".
Default: "C".
like (numba.core.types.npytypes.Array, optional): A type for
reference object to allow the creation of arrays which are not
`NumPy` arrays. If an array-like passed in as `like` supports the
`__array_function__` protocol, the result will be defined by it.
In this case, it ensures the creation of an array object
compatible with that passed in via this argument.
device (numba.core.types.misc.StringLiteral, optional): array API
concept of device where the output array is created. `device`
can be `None`, a oneAPI filter selector string, an instance of
Expand Down Expand Up @@ -278,7 +270,6 @@ def impl(
shape,
dtype=None,
order="C",
# like=None, see issue https://github.com/IntelPython/numba-dpex/issues/998
device=None,
usm_type="device",
sycl_queue=None,
Expand All @@ -287,7 +278,6 @@ def impl(
shape,
_dtype,
order,
# like, see issue https://github.com/IntelPython/numba-dpex/issues/998
_device,
_usm_type,
sycl_queue,
Expand All @@ -309,7 +299,6 @@ def ol_dpnp_zeros(
shape,
dtype=None,
order="C",
like=None,
device=None,
usm_type="device",
sycl_queue=None,
Expand All @@ -327,12 +316,6 @@ def ol_dpnp_zeros(
Default: None.
order (str, optional): memory layout for the array "C" or "F".
Default: "C".
like (numba.core.types.npytypes.Array, optional): A type for
reference object to allow the creation of arrays which are not
`NumPy` arrays. If an array-like passed in as `like` supports the
`__array_function__` protocol, the result will be defined by it.
In this case, it ensures the creation of an array object
compatible with that passed in via this argument.
device (numba.core.types.misc.StringLiteral, optional): array API
concept of device where the output array is created. `device`
can be `None`, a oneAPI filter selector string, an instance of
Expand Down Expand Up @@ -376,7 +359,6 @@ def impl(
shape,
dtype=None,
order="C",
like=None,
device=None,
usm_type="device",
sycl_queue=None,
Expand All @@ -385,7 +367,6 @@ def impl(
shape,
_dtype,
order,
like,
_device,
_usm_type,
sycl_queue,
Expand All @@ -407,7 +388,6 @@ def ol_dpnp_ones(
shape,
dtype=None,
order="C",
like=None,
device=None,
usm_type="device",
sycl_queue=None,
Expand All @@ -425,12 +405,6 @@ def ol_dpnp_ones(
Default: None.
order (str, optional): memory layout for the array "C" or "F".
Default: "C".
like (numba.core.types.npytypes.Array, optional): A type for
reference object to allow the creation of arrays which are not
`NumPy` arrays. If an array-like passed in as `like` supports the
`__array_function__` protocol, the result will be defined by it.
In this case, it ensures the creation of an array object
compatible with that passed in via this argument.
device (numba.core.types.misc.StringLiteral, optional): array API
concept of device where the output array is created. `device`
can be `None`, a oneAPI filter selector string, an instance of
Expand Down Expand Up @@ -474,7 +448,6 @@ def impl(
shape,
dtype=None,
order="C",
like=None,
device=None,
usm_type="device",
sycl_queue=None,
Expand All @@ -483,7 +456,6 @@ def impl(
shape,
_dtype,
order,
like,
_device,
_usm_type,
sycl_queue,
Expand Down