Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/overload dimensions attribute for indexers #1359

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Feature/overload dimensions attribute for indexers #1359

merged 3 commits into from
Feb 23, 2024

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Feb 23, 2024 •
edited by diptorupd
Loading

  • Rename ndim to dimensions for Item and NdItem to follow sycl syntax
  • Add dimensions for Group
  • Add dimensions overload for Group, Item and NdItem

Checklist

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa self-assigned this Feb 23, 2024
@ZzEeKkAa ZzEeKkAa force-pushed the feature/overload_dimensions_attribute_for_indexers branch from da1775c to c451ec1 Compare February 23, 2024 19:17
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review February 23, 2024 19:20
@ZzEeKkAa ZzEeKkAa force-pushed the feature/overload_dimensions_attribute_for_indexers branch from c451ec1 to 554e52d Compare February 23, 2024 19:22
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd February 23, 2024 19:23
diptorupd
diptorupd approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@diptorupd diptorupd merged commit 99c4aa1 into main Feb 23, 2024
54 of 59 checks passed
@diptorupd diptorupd deleted the feature/overload_dimensions_attribute_for_indexers branch February 23, 2024 20:10
github-actions bot added a commit that referenced this pull request Feb 23, 2024
@github-actions
Merge pull request #1359 from IntelPython/feature/overload_dimensions…
8552f52 
…_attribute_for_indexers

Feature/overload dimensions attribute for indexers 99c4aa1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

Assignees

@ZzEeKkAa ZzEeKkAa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZzEeKkAa @diptorupd