Use enum values for kernel arg types if dpctl >= 0.17 #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diptorupd
force-pushed
the
fixup/update_dpctl_kernelargtys
branch
2 times, most recently
from
f70c06a to
7f75500
Compare
6 tasks
13 tasks
diptorupd
force-pushed
the
fixup/update_dpctl_kernelargtys
branch
from
c3e02d7 to
eeb3145
Compare
github-actions bot
added a commit
that referenced
this pull request
Mar 9, 2024
…gtys Use enum values for kernel arg types if dpctl >= 0.17 b17745c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you provided a meaningful PR description?
Updated the DPCTLKernelArgType enum values to be aligned with C++11 types dpctl#1581 updated the enum values for DPCTLSyclKernelArgTy and also introduced a Python enum to track the libsyclinterface values. The current numba-dpex PR uses the latest API and enum from dpctl if the semantic version of dpctl is 0.17 or greater. Old behavior is retained for backward compatibility.
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
If this PR is a work in progress, are you filing the PR as a draft?