Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/inline threshold #1385

Merged
merged 4 commits into from
Mar 15, 2024
Merged

Feature/inline threshold #1385

merged 4 commits into from
Mar 15, 2024

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Mar 15, 2024 •
edited
Loading

Set default value of inline threshold to 2.
Some minor changes:

  • Adds NUMBA_DPEX_BUILD_KERNEL_OPTIONS environment variable to set driver compilation flags directly.
  • Disables any device side optimization to prevent catching bugs related to the driver optimizations.
  • Disables high level optimization warnings.

Checklist:

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa self-assigned this Mar 15, 2024
@ZzEeKkAa ZzEeKkAa force-pushed the feature/inline_threashold branch 4 times, most recently from f846dd0 to 4edf1ce Compare March 15, 2024 19:14
@ZzEeKkAa ZzEeKkAa changed the title WIP: Feature/inline threashold WIP: Feature/inline threahold Mar 15, 2024
@ZzEeKkAa ZzEeKkAa changed the title WIP: Feature/inline threahold WIP: Feature/inline threshold Mar 15, 2024
@ZzEeKkAa ZzEeKkAa changed the title WIP: Feature/inline threshold Feature/inline threshold Mar 15, 2024
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review March 15, 2024 19:18
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd March 15, 2024 19:18
@ZzEeKkAa ZzEeKkAa force-pushed the feature/inline_threashold branch from 4edf1ce to 4b0158c Compare March 15, 2024 20:04
@ZzEeKkAa ZzEeKkAa marked this pull request as draft March 15, 2024 20:06
@ZzEeKkAa ZzEeKkAa force-pushed the feature/inline_threashold branch 2 times, most recently from 7fbed0a to 3781020 Compare March 15, 2024 21:56
@ZzEeKkAa ZzEeKkAa force-pushed the feature/inline_threashold branch from 3781020 to cf9d335 Compare March 15, 2024 22:33
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review March 15, 2024 22:33
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 82.781% (-0.02%) from 82.805%
when pulling cf9d335 on feature/inline_threashold
into 0490fb0 on main.

diptorupd
diptorupd approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@diptorupd diptorupd merged commit e84ddce into main Mar 15, 2024
58 of 62 checks passed
@diptorupd diptorupd deleted the feature/inline_threashold branch March 15, 2024 23:38
github-actions bot added a commit that referenced this pull request Mar 15, 2024
@github-actions
Merge pull request #1385 from IntelPython/feature/inline_threashold
a8182e7 
Feature/inline threshold e84ddce
github-actions bot added a commit to diptorupd/numba-dpex that referenced this pull request Mar 17, 2024
@github-actions
Merge pull request IntelPython#1385 from IntelPython/feature/inline_t…
21a5035 
…hreashold

Feature/inline threshold e84ddce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

Assignees

@ZzEeKkAa ZzEeKkAa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZzEeKkAa @coveralls @diptorupd