Feature/move experimental decorators to stable #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diptorupd
force-pushed
the
feature/move_experimental_decorators_to_stable
branch
from
10d3081 to
6deac11
Compare
diptorupd
force-pushed
the
feature/move_experimental_decorators_to_stable
branch
from
6deac11 to
737eebf
Compare
|
@ZzEeKkAa The PR in one shot migrates user-facing features ( I have also updated all tests, examples, and API docs. Sorry for the huge diff, but will like you to review it once before I merge. I have kept the commits separate from each other so you can go commit be commit if that helps. |
|
Documentation preview: show. |
added 11 commits
March 22, 2024 16:35
diptorupd
force-pushed
the
feature/move_experimental_decorators_to_stable
branch
from
345c5b2 to
6ff53ea
Compare
diptorupd
force-pushed
the
feature/move_experimental_decorators_to_stable
branch
from
6ff53ea to
d0ad17e
Compare
ZzEeKkAa
reviewed
Mar 22, 2024
| @@ -137,4 +138,11 @@ def parse_sem_version(version_string: str) -> Tuple[int, int, int]: | |||
| __version__ = get_versions()["version"] | |||
| del get_versions | |||
|
|
|||
| __all__ = types.__all__ + ["Range", "NdRange", "call_kernel"] | |||
| __all__ = types.__all__ + [ | |||
| "call_kernel", | |||
There was a problem hiding this comment.
Suggested change
| "call_kernel", | |
| "call_kernel", | |
| "call_kernel_async", |
ZzEeKkAa
force-pushed
the
feature/move_experimental_decorators_to_stable
branch
from
c1b9071 to
fb5642c
Compare
|
Documentation preview removed. |
github-actions bot
added a commit
that referenced
this pull request
Mar 23, 2024
…ecorators_to_stable Feature/move experimental decorators to stable b186528
github-actions bot
added a commit
to diptorupd/numba-dpex
that referenced
this pull request
Mar 24, 2024
…erimental_decorators_to_stable Feature/move experimental decorators to stable b186528
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates the
kernelanddevice_funcdecorators fromexperimentaltocore.Steps:
Improve docstrings [Done]
Copy the two decorators into
core.decoratorsand replace/remove the existingkernelandfuncdecorators. We are copying so that all tests still work and we do not do massive changes in one commit.Update all tests to use decorators from top-level
numba_dpexmodule instead ofexperimental.Remove
experimental.decorators.Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
If this PR is a work in progress, are you filing the PR as a draft?
Fixes #1071
Fixes #1395
Fixes #319