Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/migrate parfor #1424

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Feature/migrate parfor #1424

merged 3 commits into from
Apr 3, 2024

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Apr 2, 2024 •
edited
Loading

Get rid of dpex.get_global_id and dpex.local.array from reduction kernels

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa requested a review from diptorupd April 2, 2024 23:08
@ZzEeKkAa ZzEeKkAa self-assigned this Apr 2, 2024
@coveralls
Copy link
Collaborator

coveralls commented Apr 2, 2024 •
edited
Loading

Coverage Status

coverage: 84.317% (-0.9%) from 85.2%
when pulling 40c465b on feature/migrate_parfor
into 5fb6093 on main.

@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review April 3, 2024 18:51
@ZzEeKkAa ZzEeKkAa changed the title WIP: Feature/migrate parfor Feature/migrate parfor Apr 3, 2024
@ZzEeKkAa ZzEeKkAa force-pushed the feature/migrate_parfor branch from 62fe934 to 40c465b Compare April 3, 2024 19:00
diptorupd
diptorupd approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well reduction parfor lives to fight another day! Thank you!

@ZzEeKkAa ZzEeKkAa merged commit e52b423 into main Apr 3, 2024
48 of 57 checks passed
@ZzEeKkAa ZzEeKkAa deleted the feature/migrate_parfor branch April 3, 2024 19:59
github-actions bot added a commit that referenced this pull request Apr 3, 2024
@github-actions
Merge pull request #1424 from IntelPython/feature/migrate_parfor
75f01a5 
Feature/migrate parfor e52b423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

Assignees

@ZzEeKkAa ZzEeKkAa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZzEeKkAa @coveralls @diptorupd