Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix windows wheels copy cmd #1430

Merged
merged 1 commit into from
Apr 5, 2024
Merged

fix windows wheels copy cmd #1430

merged 1 commit into from
Apr 5, 2024

Conversation

ekomarova
Copy link
Contributor

@ekomarova ekomarova commented Apr 5, 2024 •
edited
Loading

This PR fixes the windows wheel copying by returning it to the previous cmd. We don't need to store anything in the artifacts except the wheel package. Also, for some reason, cmd does not work correctly and does not save anything in the artifacts at all and the wheel package is missing

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@coveralls
Copy link
Collaborator

coveralls commented Apr 5, 2024 •
edited
Loading

Coverage Status

coverage: 87.201%. remained the same
when pulling 2f44293 on fix_wheels
into 25daa86 on main.

@ekomarova
Copy link
Contributor Author

Now windows wheel is present in the artifacts, as it should be

@ekomarova ekomarova requested review from diptorupd and ZzEeKkAa April 5, 2024 13:31
ZzEeKkAa
ZzEeKkAa approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It looks like copy supports wildcards in different way from .bat default behavior. Good catch

@diptorupd diptorupd merged commit 6b89cb0 into main Apr 5, 2024
54 of 58 checks passed
@diptorupd diptorupd deleted the fix_wheels branch April 5, 2024 19:47
github-actions bot added a commit that referenced this pull request Apr 5, 2024
@github-actions
Merge pull request #1430 from IntelPython/fix_wheels
5da95b6 
fix windows wheels copy cmd 6b89cb0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZzEeKkAa ZzEeKkAa ZzEeKkAa approved these changes

@oleksandr-pavlyk oleksandr-pavlyk Awaiting requested review from oleksandr-pavlyk oleksandr-pavlyk is a code owner

@diptorupd diptorupd Awaiting requested review from diptorupd

Assignees
No one assigned
Labels
2 - Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ekomarova @coveralls @ZzEeKkAa @diptorupd