-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate parfor to SPIRVKernelDispatcher #1435
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZzEeKkAa
force-pushed
the
fix/windows-parfor
branch
from
April 11, 2024 14:43
dc00ece
to
b99856e
Compare
ZzEeKkAa
force-pushed
the
fix/windows-parfor
branch
2 times, most recently
from
April 26, 2024 20:47
751e164
to
eacca8a
Compare
ZzEeKkAa
force-pushed
the
fix/windows-parfor
branch
from
April 29, 2024 15:46
5712ef4
to
e0ec053
Compare
diptorupd
reviewed
Apr 29, 2024
diptorupd
reviewed
Apr 29, 2024
ZzEeKkAa
force-pushed
the
fix/windows-parfor
branch
3 times, most recently
from
April 29, 2024 17:29
b195715
to
97ad569
Compare
ZzEeKkAa
changed the title
WIP: Migrate parfor to SPIRVKernelDispatcher
Migrate parfor to SPIRVKernelDispatcher
Apr 29, 2024
ZzEeKkAa
commented
Apr 29, 2024
ZzEeKkAa
force-pushed
the
fix/windows-parfor
branch
2 times, most recently
from
April 29, 2024 22:02
a04de96
to
99477d4
Compare
ZzEeKkAa
force-pushed
the
fix/windows-parfor
branch
from
April 29, 2024 22:07
99477d4
to
41b5d25
Compare
diptorupd
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are few cleanups such as introducing a new pipeline fr parfor kernel compilation that should be done, can be handled in later PR.
Overall nice set of changes. The parfor kernel generator has become much cleaner after these changes.
github-actions bot
added a commit
that referenced
this pull request
Apr 30, 2024
Migrate parfor to SPIRVKernelDispatcher 675cb79
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done:
SpirvDispatcher
.__seninel__ = 0
. Ideally it must be replace to some internal dedicated function call likenumba_dpex.core.insert_parfor_body()
.Checklist: