Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Required fixes to run test suite on Max GPU #1451

Merged
merged 3 commits into from
May 7, 2024
Merged

Required fixes to run test suite on Max GPU #1451

merged 3 commits into from
May 7, 2024

Conversation

diptorupd
Copy link
Contributor

  • Have you provided a meaningful PR description?
  • The PR introduces changes to the gdb-oneapi unit tests to support running the tests on Intel Max GPU.
  • Updated the test_intenum_literal_codegen.py test case to handle a corner case that was identified during testing on Intel Max GPU.
  • Loads the SPV_INTEL_variable_length_array SPIR-V extension for llvm-spirv translation as it is required for supporting private arrays on Intel Max GPU.
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@diptorupd diptorupd requested a review from ZzEeKkAa May 7, 2024 00:45
@coveralls
Copy link
Collaborator

coveralls commented May 7, 2024 •
edited
Loading

Coverage Status

coverage: 86.48% (-0.01%) from 86.494%
when pulling ab45e5d on fix/changes-required-on-dgpu
into 84acdea on main.

Changes to gdb unit tests to enable them on Intel Max GPU
655aa8b 
    - Increase the timeout value for pyexpect as spawning gdb
      on discrete GPU can take more time than on CPU.
    - Slight modifications on the regex patterns to be matched
      on hitting a breakpoint. The change was done based on
      what was observed on Intel Max GPU and gdb-oneapi.
@diptorupd diptorupd force-pushed the fix/changes-required-on-dgpu branch from 8d386b0 to 4236b69 Compare May 7, 2024 16:03
ZzEeKkAa
ZzEeKkAa previously approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! Thank you!

Diptorup Deb added 2 commits May 7, 2024 11:19
Updates test case verifying codegen for intenum literal args.
40a51c7 
    - Allows expected regex to match even when "nonnull" qualifier
      was not found on retval pointer argument of a function call.
The SPV_INTEL_variable_lenght_array SPIRV ext. is needed on PVC.
ab45e5d
@diptorupd diptorupd force-pushed the fix/changes-required-on-dgpu branch from 4236b69 to ab45e5d Compare May 7, 2024 16:19
@diptorupd diptorupd enabled auto-merge May 7, 2024 16:58
@diptorupd diptorupd merged commit ab500b6 into main May 7, 2024
74 of 76 checks passed
@diptorupd diptorupd deleted the fix/changes-required-on-dgpu branch May 7, 2024 17:40
github-actions bot added a commit that referenced this pull request May 7, 2024
@github-actions
Merge pull request #1451 from IntelPython/fix/changes-required-on-dgpu
41f6c23 
Required fixes to run test suite on Max GPU ab500b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZzEeKkAa ZzEeKkAa ZzEeKkAa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diptorupd @coveralls @ZzEeKkAa