Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nrt api to allocate meminfo object #1458

Merged
merged 1 commit into from
May 14, 2024
Merged

Use nrt api to allocate meminfo object #1458

merged 1 commit into from
May 14, 2024

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented May 14, 2024 •
edited
Loading

Replace NRT_MemInfo allocation from std's malloc to NRT API, so they handle the same way for the whole lifetime. Was causing crashes under expect tests

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@coveralls
Copy link
Collaborator

coveralls commented May 14, 2024 •
edited
Loading

Coverage Status

coverage: 86.5% (+0.02%) from 86.48%
when pulling 0364e76 on fix/memory_allocation
into 574daab on main.

@ZzEeKkAa ZzEeKkAa force-pushed the fix/memory_allocation branch from af44736 to ca665b2 Compare May 14, 2024 22:04
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd May 14, 2024 22:06
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review May 14, 2024 22:06
diptorupd
diptorupd previously approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks great barring minor nit.

@ZzEeKkAa ZzEeKkAa enabled auto-merge May 14, 2024 22:13
@ZzEeKkAa ZzEeKkAa force-pushed the fix/memory_allocation branch from ca665b2 to 0364e76 Compare May 14, 2024 22:14
@diptorupd diptorupd self-requested a review May 14, 2024 22:22
@diptorupd diptorupd mentioned this pull request May 14, 2024
Merged
@ZzEeKkAa ZzEeKkAa merged commit c9a5237 into main May 14, 2024
55 of 69 checks passed
@ZzEeKkAa ZzEeKkAa deleted the fix/memory_allocation branch May 14, 2024 22:41
github-actions bot added a commit that referenced this pull request May 14, 2024
@github-actions
Merge pull request #1458 from IntelPython/fix/memory_allocation
a7ce280 
Use nrt api to allocate meminfo object c9a5237
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZzEeKkAa @coveralls @diptorupd