Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to dpnp 0.9 #599

Merged
merged 13 commits into from
Oct 28, 2021
Merged

Update to dpnp 0.9 #599

merged 13 commits into from
Oct 28, 2021

Conversation

PokhodenkoSA
Copy link
Contributor

No description provided.

@PokhodenkoSA
Copy link
Contributor Author

Test test_consuming_array_from_dpnp fails b/c dpnp.arange() and other dpnp functions returns dpnp_array.
dpnp_array is wrapper for dpctl.tensor.usm_array.
I have implemented dirty implementation for support for dpnp_array but it is not acceptable.
@reazulhoque could look up please and propose better layout for code?

@PokhodenkoSA
Copy link
Contributor Author

PokhodenkoSA commented Oct 23, 2021 •
edited
Loading

Need access to some usm_array attributes via dpnp_array: IntelPython/dpnp#1028

@PokhodenkoSA
Copy link
Contributor Author

PokhodenkoSA commented Oct 25, 2021 •
edited
Loading

@reazulhoque
As I understand current implementation uses containers types.
But correct implementation should rely on __sycl_usm_array_interface__. Correct?

@PokhodenkoSA
Copy link
Contributor Author

PokhodenkoSA commented Oct 25, 2021 •
edited
Loading

@oleksandr-pavlyk
Interoperability requires explicit conversion of dpnp_array to dpctl.tensor.usm_array. So only test should be changed.
Correct? What is the function for that?

@PokhodenkoSA
Copy link
Contributor Author

PokhodenkoSA commented Oct 25, 2021 •
edited
Loading

numba-dppy will use asarray() function from dpctl. Possibly numba-dppy will have its own numba_dppy.asarray() as alias to the function from dpctl.

@PokhodenkoSA
Copy link
Contributor Author

Rely on dpctl support for asarray - IntelPython/dpctl#640

PokhodenkoSA
PokhodenkoSA commented Oct 27, 2021
View reviewed changes
conda-recipe/meta.yaml Outdated Show resolved Hide resolved
@PokhodenkoSA PokhodenkoSA mentioned this pull request Oct 28, 2021
Closed
@PokhodenkoSA
Copy link
Contributor Author

PokhodenkoSA commented Oct 28, 2021 •
edited
Loading

dpnp 0.9.0rc1
Freezing tests:

  • test_eig -
  • test_dot - numba_dppy/tests/njit_tests/dpnp/test_numpy_linalg.py::test_dot[opencl:gpu:0-dot-dot_input0-float32]
  • test_matmul
  • test_eigvals
  • test_matrix_power - numba_dppy/tests/njit_tests/dpnp/test_numpy_linalg.py::test_matrix_power[opencl:gpu:0-matrix_power_input0-2-float32]
  • test_unary_ops - numba_dppy/tests/njit_tests/dpnp/test_numpy_statistics.py::test_unary_ops[opencl:gpu:0-cov-int32-100]

@PokhodenkoSA PokhodenkoSA mentioned this pull request Oct 28, 2021
Closed
@PokhodenkoSA PokhodenkoSA merged commit addaf4b into main Oct 28, 2021
github-actions bot pushed a commit that referenced this pull request Oct 28, 2021
@PokhodenkoSA
Update to dpnp 0.9 (#599)
c8457c9 
* Update recipe
* Update README
* Update docs
* Update environment.yml
* Add asarray()
* Use asarray from dpctl.tensor
* Skip freezing tests addaf4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reazulhoque reazulhoque Awaiting requested review from reazulhoque

@oleksandr-pavlyk oleksandr-pavlyk Awaiting requested review from oleksandr-pavlyk oleksandr-pavlyk is a code owner

Assignees

@PokhodenkoSA PokhodenkoSA

Labels
dpnp Integration with dpnp enhancement New feature or request
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.
1 participant
@PokhodenkoSA