-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kernel examples refactoring #826
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
samaid
commented
Nov 29, 2022
- [Y] Have you provided a meaningful PR description?
- [N] Have you added a test, reproducer or referred to an issue with a reproducer?
- [N] Have you tested your changes locally for CPU and GPU devices?
- [N] Have you made sure that new changes do not introduce compiler warnings?
- [Y] If this PR is a work in progress, are you filing the PR as a draft?
diptorupd
force-pushed
the
samaid_examples_refactor
branch
2 times, most recently
from
December 7, 2022 16:12
3ea1dce
to
6693469
Compare
mingjie-intel
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skipped scan.py for now.
Can be merged.
diptorupd
force-pushed
the
samaid_examples_refactor
branch
2 times, most recently
from
December 7, 2022 22:53
0bbc713
to
0a8262a
Compare
@samaid @mingjie-intel As the PR only impacts the examples and the public CI where we test examples is green, I am merging the PR. The windows CI failures in TeamCity must be some unrelated infrastructure issue and not due to the PR. |
github-actions bot
added a commit
that referenced
this pull request
Dec 8, 2022
Add new kernel examples and restructure the existing kernel examples. 3cef533
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.