Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves USMNdArrayType into numba_dpex/core. #851

Merged
merged 2 commits into from
Dec 17, 2022
Merged

Conversation

diptorupd
Copy link
Collaborator

@diptorupd diptorupd commented Dec 17, 2022

  • Have you provided a meaningful PR description?
    • Introduces a numba like module organization for types.
    • Renames USMNdArrayType to USMNdArray
    • Changes and improvements to USMNdArray
      • Now directly inherits from numba.core.types.Array
      • Stores a device filter string attribute
      • Properly handle non-C contiguous layouts in the type definition
    • Add type aliases and short names for numba scalar types directly into numba-dpex
    • Needed updates to imports.
  • Have you added a test, reproducer or referred to an issue with a reproducer?
    Existing tests were updated.
  • Have you tested your changes locally for CPU and GPU devices?
    Yes

Fixes #830

   - Introduces a numba like module organization for
     types.
   - Improvements to USMNdArrayType.
   - Needed updates to imports.
@diptorupd diptorupd merged commit 511a3c5 into main Dec 17, 2022
@diptorupd diptorupd deleted the refactor/USMNdArrayType branch December 17, 2022 19:18
github-actions bot added a commit that referenced this pull request Dec 17, 2022
Moves USMNdArrayType into numba_dpex/core. 511a3c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create aliases to numba's primitive data types in numba-dpex
1 participant