Bump dpctl version requirement to 0.14 and fix issue caused by API change #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
added a commit
that referenced
this pull request
Jan 7, 2023
Bump dpctl version requirement to 0.14 and fix issue caused by API change a541db5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are API changes in dpctl 0.14.1dev1 to accommodate changes in dpcpp 2023.0. Specifically,
dpctl.SyclDeviceno longer has theis_hostproperty. The change impacts the check insidenumba_dpex.config._dpctl_has_non_host_devicethat was throwing an uncaughtAttributeError.The PR fixes the issue by using only
dpctl.select_default_device(). Also the minimum dpctl version required was bumped to 0.14.