Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NumPy argument support for dpex kernels #866

Closed
wants to merge 55 commits into from

Commits on Jan 10, 2023

  1. Move passbuilder into core.

    diptorupd committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    f4d916c View commit details
    Browse the repository at this point in the history
  2. Add a compiler module into core.

       - The compiler module only contains the compiler pipeline
         to compiler SpirvKernel objects.
    diptorupd committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    7c626b5 View commit details
    Browse the repository at this point in the history
  3. Adds an arg_pack_unpack module to kernel_interface

       - Creates a separate module for the unpack and pack
         functions for kernel arguments.
       - The new API is intended for use from the Dispatcher class.
    diptorupd committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    077ca33 View commit details
    Browse the repository at this point in the history
  4. Change exception behavior

    diptorupd committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    d8f81a6 View commit details
    Browse the repository at this point in the history
  5. Refactored kernel dispatch API.

      - The concept of a kernel was decoupled from the notion of
        dispatching of a kernel. The present implementation in
        compiler.py intermixes both things, making hard the
        separation of compute-follows-data based kernel launch
        and legacy `dpctl.device_context` based behavior.
      - Deprecates support for numpy arrays as kernel args.
      - Deprecates support for the square bracket notation using
        `__getitem__` to provide global and local ranges for a
        kernel launch.
      - Changes the behavior of specializing a kernel using only
        a signature. The new way to specialize will require a
        device type and a backend.
      - Improvements to exception messages using custom exceptions.
      - The new API is now inside `numba_dpex.core.kernel_interface`.
    diptorupd committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    3ab688f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8e3e18a View commit details
    Browse the repository at this point in the history
  7. Improve exceptions.

    diptorupd committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    0c7374f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    80fa3f7 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b362b76 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    b69aa50 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    72ec9cc View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    59df7b9 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    b4ab99f View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    f503061 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    0eafa3f View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    038e593 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    8bc0c0c View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    5dd94c8 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    973f41b View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    d732b49 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    f1bcac3 View commit details
    Browse the repository at this point in the history
  22. Added rst for caching

    Fix docs rst
    chudur-budur authored and diptorupd committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    a54c23a View commit details
    Browse the repository at this point in the history
  23. Fix type import.

    diptorupd committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    667d081 View commit details
    Browse the repository at this point in the history
  24. Bring back support for kernel specialization.

       - Kernel specialization for specific signatures was fixed.
       - Specialization is only allowed for usm_ndarray.
       - Dispacther class was renamed as JitKernel.
       - decorators updated.
    diptorupd committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    28cff46 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    1ddbab2 View commit details
    Browse the repository at this point in the history
  26. Fix driver

    diptorupd committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    8726ad7 View commit details
    Browse the repository at this point in the history
  27. Fix formatting issues.

    diptorupd committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    2468b97 View commit details
    Browse the repository at this point in the history
  28. Improvements to USMNdArrayType.

       - print a better type name with keywords and all attributes.
       - store a fully qualified filter string in the type.
       - set the default address space to GLOBAL instead of None.
       - fix the unify function to test on usm_type, device, address
         space.
    diptorupd committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    99f51e7 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    7e1c102 View commit details
    Browse the repository at this point in the history
  30. Add unit tests for kernel specialization.

       - Added unit tests for the kernel specialization feature.
       - Fix kernel decorator to support list of signatures.
       - Disallow JIT compilation of a specialized kernel and raise
         an exception.
    diptorupd committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    be7fe42 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    fd7c370 View commit details
    Browse the repository at this point in the history
  32. Improve support for SUAI arrays as kernel arguments.

        - Move sycl_usm_array_interface helper functions into core/utils.
        - Move array type conversion function for unknown type with
          sycl_usm_array_interface to UsmNdArray into core/typeconv.
        - Fix how the UsmNdArray type is constructed for unknow
          sycl_usm_array_interface arrays.
    diptorupd committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    292c57a View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    f5fa531 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    cb15e0a View commit details
    Browse the repository at this point in the history
  35. Address review comments.

       - Move compile_with_dpex into the core.compiler module.
       - The target and typing contexts are now not set from dpex_target
         inside the SpirvKernel.compile. They are passed in as args.
       - Fix tests impacted by these changes.
    diptorupd committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    6ef0637 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    5e15920 View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    d183c7a View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    c7d1270 View commit details
    Browse the repository at this point in the history
  39. Added ndarray setup check.

    mingjie-intel authored and diptorupd committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    1d65949 View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    1c9dd0f View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    479197b View commit details
    Browse the repository at this point in the history
  42. Fix deprecation warnings.

    diptorupd committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    1bc8cdd View commit details
    Browse the repository at this point in the history
  43. Configuration menu
    Copy the full SHA
    3dd71c8 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. Clean up numpy array.

    mingjie-intel committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    814762b View commit details
    Browse the repository at this point in the history
  2. Clean up numpy array.

    mingjie-intel committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    db37ef1 View commit details
    Browse the repository at this point in the history
  3. Add docsstrings.

    diptorupd committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    dd47913 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    057f470 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0a70dd9 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. Clean up NumPy array.

    Removed test_black_scholes.py.
    Renamed dppy to dpex in two test files.
    mingjie-intel committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    ed74dd5 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2023

  1. Changes to compute-follows-data implementation and specialization.

       - The compute follows data checking is now based on queue
         equality.
       - USMNdArray no longer requires usm_type and device
         during construction. It allows us to specialize an usm_ndarray
         only on ndims, layout and dtype.
       - No check for compute follows data for eager compilation.
       - Change caching to not require backend and device-type.
       - Fixes to test cases.
    diptorupd committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    7d4bee9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    63acaee View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ac496ac View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2023

  1. Configuration menu
    Copy the full SHA
    7e077d0 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. Configuration menu
    Copy the full SHA
    ce00025 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3cdd4f6 View commit details
    Browse the repository at this point in the history