Move CFD-related fucntions to a separate module. #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The compute follows data related functions are
required in parfor lowering as well. The PR moves
the two functions determine_kernel_launch_queue and
chk_compute_follows_data_compliance out of
kernel_interface/dispatcher.py into kernel_interface/utils.py
and makes them public.
- The Range and NdRange classes are moved to
kernel_interface/indexers.py
diptorupd
force-pushed
the
Make-cfd-checks-public
branch
from
a2a80cb
to
aa2c8b7
Compare
github-actions bot
added a commit
that referenced
this pull request
Feb 20, 2023
Move CFD-related fucntions to a separate module. 56e7129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you provided a meaningful PR description?
determine_kernel_launch_queueandchk_compute_follows_data_complianceout of kernel_interface/dispatcher.py into kernel_interface/utils.py and makes them public.Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
If this PR is a work in progress, are you filing the PR as a draft?