Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ImportError with logging.warning if dpctl version is not met #925

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

oleksandr-pavlyk
Copy link
Contributor

If dpctl was built from source without .git folder present, dpctl.__version__ is 0+unknown and dpctl_version computation in numba_dpex/dpctl_support.py broke down.

Introduced function to safely infer dpctl_version, and modified config.py to issue soft logging.warning about unmet dpctl version instead of raising hard ImportError.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@diptorupd
Copy link
Collaborator

Merge based on public CI.

@diptorupd diptorupd merged commit 63b8796 into main Feb 21, 2023
@diptorupd diptorupd deleted the soften-dpctl-version-check branch February 21, 2023 22:14
github-actions bot added a commit that referenced this pull request Feb 21, 2023
Replace ImportError with logging.warning if dpctl version is not met 63b8796
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants