Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation for dpnp.full_like() #997

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Implementation for dpnp.full_like() #997

merged 1 commit into from
Apr 14, 2023

Conversation

chudur-budur
Copy link
Contributor

@chudur-budur chudur-budur commented Apr 12, 2023 •
edited
Loading

Implementation for dpnp.full_like().

This will enable calling dpnp.full_like() inside @dpjit functions.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@chudur-budur
Copy link
Contributor Author

Keeping track on #254

@chudur-budur chudur-budur mentioned this pull request Apr 12, 2023
Open
20 tasks
@chudur-budur chudur-budur force-pushed the feature/dpnp.full_like branch from 6206b29 to 13d2618 Compare April 12, 2023 16:35
@chudur-budur chudur-budur marked this pull request as ready for review April 12, 2023 16:35
@chudur-budur chudur-budur force-pushed the feature/dpnp.full_like branch from 13d2618 to 5b662a7 Compare April 13, 2023 23:56
Add an overload for dpnp.full_like
3a7ea5e 
    - Adds an overload for the dpnp.full_like array constructor
    - Adds unit tests for the new overload
@diptorupd diptorupd force-pushed the feature/dpnp.full_like branch from 11abd35 to 3a7ea5e Compare April 14, 2023 19:03
diptorupd
diptorupd approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@diptorupd diptorupd merged commit f9a77a2 into IntelPython:main Apr 14, 2023
@diptorupd diptorupd deleted the feature/dpnp.full_like branch April 14, 2023 21:20
github-actions bot added a commit that referenced this pull request Apr 14, 2023
@github-actions
Merge pull request #997 from chudur-budur/feature/dpnp.full_like
ca96db8 
Implementation for dpnp.full_like() f9a77a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

@mingjie-intel mingjie-intel Awaiting requested review from mingjie-intel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chudur-budur @diptorupd