Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C6287 Redundant Code in zero-order.cpp, probably from a cut/paste error #5733

Closed
JTrantow opened this issue Jan 28, 2020 · 1 comment
Closed

C6287 Redundant Code in zero-order.cpp, probably from a cut/paste error #5733

JTrantow opened this issue Jan 28, 2020 · 1 comment

Comments

@JTrantow
Copy link
Contributor

Required Info
Camera Model { D400 }
Firmware Version NA
Operating System & Version Win10
Platform PC
SDK Version { 2.}
Language {C++ }

Issue Description

zero-order.cpp try_get_zo_rtd_ir_point_values() contains a line testing values.rtd.size() twice.

    if (values_rtd.size() == 0 || values_rtd.size() == 0)

Looks like a classic cut and paste error that should be

    if ((values_rtd.size() == 0) || (values_ir.size() == 0))
@JTrantow JTrantow mentioned this issue Jan 28, 2020
Merged
dorodnic added a commit that referenced this issue Feb 6, 2020
@dorodnic
Merge pull request #5734 from rpadak/pull5733
1681e6d 
Fix what appears to be a copy/paste redundant code problem. Issue #5733
@dorodnic
Copy link
Contributor

Hi @JTrantow
Thanks for the fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JTrantow @dorodnic