Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding support for y16i - 10 MSB #10737

Merged
merged 6 commits into from
Sep 4, 2022
Merged

adding support for y16i - 10 MSB #10737

merged 6 commits into from
Sep 4, 2022

Conversation

remibettan
Copy link
Contributor

Tracked by: LRS-464

@remibettan remibettan requested a review from ev-mp August 2, 2022 06:59
@remibettan remibettan force-pushed the y16i_support branch 2 times, most recently from 1471b15 to 0053020 Compare August 2, 2022 10:01
Nir-Az
Nir-Az reviewed Aug 2, 2022
View reviewed changes
src/proc/y16i-to-y16y16.cpp Outdated Show resolved Hide resolved
ev-mp
ev-mp reviewed Aug 2, 2022
View reviewed changes
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! some minor comments inside

src/proc/y16i-to-y16y16.cpp Outdated Show resolved Hide resolved
src/proc/y16i-to-y16y16.cpp Outdated Show resolved Hide resolved
wrappers/nodejs/src/addon.cpp Show resolved Hide resolved
@dmipx
Copy link
Contributor

dmipx commented Aug 4, 2022

try with #10745

@remibettan remibettan marked this pull request as ready for review August 31, 2022 10:38
Nir-Az
Nir-Az reviewed Aug 31, 2022
View reviewed changes
src/proc/y16i-to-y16y16.cpp Outdated Show resolved Hide resolved
ev-mp
ev-mp reviewed Sep 1, 2022
View reviewed changes
src/proc/y16i-to-y16y16.cpp Outdated Show resolved Hide resolved
@Nir-Az Nir-Az changed the title adding support for y16i - no testing available yet adding support for y16i Sep 1, 2022
@Nir-Az Nir-Az changed the title adding support for y16i adding support for y16i - 10 MSB Sep 1, 2022
Nir-Az
Nir-Az approved these changes Sep 1, 2022
View reviewed changes
Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@Nir-Az
Copy link
Collaborator

Nir-Az commented Sep 1, 2022

@ev-mp Please complete your review before I merge it.
The kernel patch PR was merged.

ev-mp
ev-mp approved these changes Sep 4, 2022
View reviewed changes
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ev-mp ev-mp merged commit 7018144 into IntelRealSense:development Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ev-mp ev-mp ev-mp approved these changes

@Nir-Az Nir-Az Nir-Az approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@remibettan @dmipx @Nir-Az @ev-mp