Enumerate video nodes by name #11319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ADL-P] LRS V4L2 Backend Enumerate video nodes by name [LRS-573] rs-enum.sh: - Create symbolic links for video nodes and for metadata nodes - /dev/video-rs-[<sensor>|<sensor>-md]-[camera-index] - Enable ipu6 link enumeration backend-v4l2.cpp: - scan for rs-enum links Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
dmipx
commented
Jan 16, 2023
dmipx
commented
Jan 16, 2023
src/linux/backend-v4l2.cpp
Outdated
| continue; | ||
| if (vfd) | ||
| ::close(vfd); | ||
| info = info = get_info_from_mipi_device_path(video_md_path, device_md_path); |
dmipx
commented
Jan 16, 2023
dmipx
commented
Jan 16, 2023
src/linux/backend-v4l2.cpp
Outdated
| @@ -838,11 +879,14 @@ namespace librealsense | |||
| { | |||
| info = get_info_from_usb_device_path(video_path, name); | |||
| } | |||
| else //video4linux devices that are not USB devices | |||
| else if(mipi_nodes.empty()) //video4linux devices that are not USB devices | |||
There was a problem hiding this comment.
and not previously enumerated by rs links
dmipx
commented
Jan 16, 2023
src/linux/backend-v4l2.cpp
Outdated
| { | ||
| info = get_info_from_mipi_device_path(video_path, name); | ||
| } | ||
|
|
||
| else |
There was a problem hiding this comment.
comment: continue as we already have mipi nodes in uvc_nodes
dmipx
commented
Jan 16, 2023
src/linux/backend-v4l2.cpp
Outdated
| @@ -838,11 +879,14 @@ namespace librealsense | |||
| { | |||
| info = get_info_from_usb_device_path(video_path, name); | |||
| } | |||
| else //video4linux devices that are not USB devices | |||
| else if(mipi_nodes.empty()) //video4linux devices that are not USB devices | |||
There was a problem hiding this comment.
change mipi_nodes to mipi_rs_enum_nodes
dmipx
commented
Jan 16, 2023
src/linux/backend-v4l2.cpp
Outdated
| typedef std::pair<uvc_device_info,std::string> node_info; | ||
| std::vector<node_info> uvc_nodes,uvc_devices; | ||
| std::vector<node_info> mipi_nodes; | ||
| /* With usage of rs-enum script */ | ||
| std::vector<std::string> video_sensors = {"depth", "rgb", "ir", "imu"}; |
There was a problem hiding this comment.
change "Rgb" to "color" ?
dmipx
commented
Jan 16, 2023
scripts/rs-enum.sh
Outdated
|
|
||
| declare -A d4xx_vc=([1]=1 [2]=3 [4]=5) | ||
| declare -A d4xx_vc_named=([depth]=1 [rgb]=3 ["motion detection"]=5 [imu]=7) | ||
| declare -A camera_names=( [depth]=depth [rgb]=rgb ["motion detection"]=ir [imu]=imu ) |
dmipx
commented
Jan 16, 2023
|
@remibettan and @Nir-Az , please review after changes |
|
@dmipx please notice the CI error It means that Jetson MIPI crash when questing for devices, please investigate.. |
Nir-Az
reviewed
Jan 16, 2023
|
|
||
| // Get metadata node | ||
| // Check if file on video_md_path is exists | ||
| vfd = open(video_md_path.c_str(), O_RDONLY | O_NONBLOCK); |
There was a problem hiding this comment.
Please add this line before:
vfd = -1;
rs-enum: add comments, change rgb to color. backend-v4l2: change rgb to color, comments, try/catch for throwing module. Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
dmipx
added a commit
to dmipx/librealsense
that referenced
this pull request
Feb 5, 2023
LRS V4L2 Backend Enumerate video nodes by name [LRS-573] rs-enum.sh: - Create symbolic links for video nodes and for metadata nodes - /dev/video-rs-[|-md]-[camera-index] backend-v4l2.cpp: - scan for rs-enum links Follow-by: IntelRealSense#11319 Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
dmipx
added a commit
to dmipx/librealsense
that referenced
this pull request
Feb 5, 2023
LRS V4L2 Backend Enumerate video nodes by name [LRS-573] rs-enum.sh: - Create symbolic links for video nodes and for metadata nodes - /dev/video-rs-[|-md]-[camera-index] backend-v4l2.cpp: - scan for rs-enum links Follow-by: IntelRealSense#11319 Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ADL-P] LRS V4L2 Backend Enumerate video nodes by name [LRS-573]
rs-enum.sh:
backend-v4l2.cpp:
Signed-off-by: Dmitry Perchanov dmitry.perchanov@intel.com