Fully qualify std::move
invocations to fix -Wunqualified-std-cast-call
#11416
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang implemented a warning last year to detect bare
move
andforward
calls, as they have the potential to be error prone: llvm/llvm-project@70b1f6d. This warning should be available in clang-15.This warning also applies to
std::forward
, but the few uses ofstd::forward
in librealsense are all fully qualified.Verified locally by using a recent version of clang and building with
-Werror=unqualified-std-cast-call
.