port tests post-processing-from bag to python #12402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maloel
reviewed
Nov 15, 2023
maloel
reviewed
Nov 15, 2023
maloel
reviewed
Nov 15, 2023
maloel
reviewed
Nov 15, 2023
maloel
reviewed
Nov 15, 2023
maloel
reviewed
Nov 15, 2023
maloel
reviewed
Nov 15, 2023
maloel
reviewed
Nov 15, 2023
Nir-Az
reviewed
Nov 19, 2023
…that is not video_frame
…mes data and its profile, do the alignment of the frameset inside process frame, remove locks, change function and variables names
maloel
reviewed
Nov 27, 2023
| frames_data_map[sensor_name] = (bytearray(frame.get_data()), frame.get_profile().as_video_stream_profile()) | ||
|
|
||
|
|
||
| def get_frames(callback): |
There was a problem hiding this comment.
I like this function, but not with the frame-list logic: it makes it less generic. Why should it know a frames_data_map, etc.? That logic should be in the caller of playback_file?
maloel
reviewed
Nov 27, 2023
|
After looking at it again after the refactor, the processing-block code is minimal and I have no problem with it. |
…es to make playback_file more generic + change variables names to more generic names
maloel
reviewed
Nov 27, 2023
| @@ -71,7 +65,7 @@ def get_frames(callback): | |||
|
|
|||
|
|
|||
| def playback_file(file, callback): | |||
| global playback_status | |||
| global playback_status, sensors | |||
There was a problem hiding this comment.
I don't like the sensors as global here...
maloel
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test align depth to color and test align color to depth
porting it from legacy live test to python tests
Tracked on LRS-872