-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port tests post-processing-from bag to python #12402
port tests post-processing-from bag to python #12402
Conversation
…that is not video_frame
…mes data and its profile, do the alignment of the frameset inside process frame, remove locks, change function and variables names
frames_data_map[sensor_name] = (bytearray(frame.get_data()), frame.get_profile().as_video_stream_profile()) | ||
|
||
|
||
def get_frames(callback): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this function, but not with the frame-list logic: it makes it less generic. Why should it know a frames_data_map, etc.? That logic should be in the caller of playback_file
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MUCH better
After looking at it again after the refactor, the processing-block code is minimal and I have no problem with it. |
…es to make playback_file more generic + change variables names to more generic names
@@ -71,7 +65,7 @@ def get_frames(callback): | |||
|
|||
|
|||
def playback_file(file, callback): | |||
global playback_status | |||
global playback_status, sensors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the sensors
as global here...
test align depth to color and test align color to depth
porting it from legacy live test to python tests
Tracked on LRS-872