misc DDS changes #12467
Merged
misc DDS changes #12467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # third-party/realdds/py/pyrealdds.cpp
# Conflicts: # third-party/realdds/py/pyrealdds.cpp
OhadMeir
reviewed
Dec 5, 2023
OhadMeir
reviewed
Dec 5, 2023
OhadMeir
reviewed
Dec 5, 2023
OhadMeir
reviewed
Dec 5, 2023
|
|
||
| with test.closure( 'from string: generic format' ): | ||
| test.check_false( dds.guid.from_string( '' ) ) | ||
| test.check_equal( repr( dds.guid.from_string( '001122334455667788990011.100' ) ), '001122334455667788990011.100' ) |
There was a problem hiding this comment.
You don't want to test here stuff that you have tested in the previous test, like hex letters or invalid characters?
There was a problem hiding this comment.
The difference is the format - chances are the same rules apply. I thought this is a good start and didn't want to spend any more time on it.
OhadMeir
reviewed
Dec 5, 2023
| dds.message.flexible( message ).write_to( writer ) | ||
| i( f'Sent {message} on {topic_path}' ) | ||
| if args.ack: | ||
| if not writer.wait_for_acks( dds.time( 5. ) ): # seconds |
There was a problem hiding this comment.
Can we take the timeout from the settings?
There was a problem hiding this comment.
Sure, but really I see no need. We can improve the script as we go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separating out from DFU PR... commits are mostly self-explanatory, but: