-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
option-value and usage in options-changed notifications #12616
Conversation
I can take a look, but I don't understand the highlight you have or the meaning... is this in the private branch? |
It also happened to me on the public branch before I completed my PR, I thought I handled all the cases. Nir showed me he had this error, I told him that you have a PR that changes the behavior, so don't know if it is still relevant. |
I'll try to reproduce. Technically I don't quite understand how... the device was destroyed while a callback was in progress? The join() wasn't blocking? |
Prequel to DDS-related bulk-query changes:
rs2::options_list
object now returnsrs2::option_value
rather than just thers2_option
rs2::option_value
now holds ars2_option_value const *
rs2_option_value
is a struct containing atype
,id
, and union ofas_float
etc.rs2_option_type
rs2_get_option_value
,rs2_delete_option_value
,rs2_option_type_to_string
,rs2_get_option_value_from_list
on_options_changed
notifications therefore now return the actual values seen so you don't need to query them again...