Extended HWM commands refactor #12682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remibettan
reviewed
Feb 20, 2024
|
|
||
| auto ans = hw_monitor::send(cmd, p_response, locked_transfer); | ||
| recv_msg.insert(recv_msg.end(), ans.begin(), ans.end()); | ||
| // currently we assume HKR send only the table size when sending 0/0 chanks command above. |
remibettan
reviewed
Feb 20, 2024
| auto ans = hw_monitor::send(cmd, p_response, locked_transfer); | ||
| recv_msg.insert(recv_msg.end(), ans.begin(), ans.end()); | ||
| // currently we assume HKR send only the table size when sending 0/0 chanks command above. | ||
| // in the future the FW should send chunk 1 in 0/0 command and than we can use it here. |
remibettan
reviewed
Feb 20, 2024
| // actual size will be returned as part for the response header and will be used | ||
| // to calculate the extended loop range | ||
| auto ans = hw_monitor::send(cmd, p_response, locked_transfer); | ||
| recv_msg.insert(recv_msg.end(), ans.begin(), ans.end()); |
There was a problem hiding this comment.
if I understand correctly, this is an API change:
instead of getting the first chunk, we get the message, in which only the header is needed, and then, we get the chunks in other messages.
Please confirm this change has been implemented also in HKR side.
There was a problem hiding this comment.
As discusses,
Current FW : we get the last chunk size of the first messages which is wrong, but since we get a valid header we extract the size from there and restart the querying process.
FW should supply a fix where 0/0 we send the first chunk with full size, then we can optimize and take this chunk and continue the loop from index 1.
This will be done on another PR once we have their fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we get config table we get the size in the header.
This PR remove the hard coded tables sizes, and leverage the header size value.
Also did some renaming
Tracked on [RSDEV-1735]