Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macos M processor compilation + GHA upgrade to use macos 14 + update upload tool version #12972

Merged
merged 5 commits into from
May 29, 2024

Conversation

Nir-Az
Copy link
Collaborator

@Nir-Az Nir-Az commented May 28, 2024

  • Fix building on M processors on macos (See CMAKE_CXX_FLAGS set wrong and fails to build on M1 Mac #11978)
  • macos-11 is soon to be deprecated --> update to macos-14
  • python-setup version is deprecated - update to v5
    Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-python@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

@Nir-Az Nir-Az force-pushed the gha-macos-14 branch 4 times, most recently from b99abd8 to d9c05bb Compare May 28, 2024 18:35
@Nir-Az Nir-Az requested a review from maloel May 29, 2024 14:08
@Nir-Az Nir-Az changed the title GHA upgrade to use macos 14 + update upload tool version Fix macos M processor compilation + GHA upgrade to use macos 14 + update upload tool version May 29, 2024
@IntelRealSense IntelRealSense deleted a comment from sysrsbuild May 29, 2024
@Nir-Az Nir-Az merged commit 6f90805 into IntelRealSense:development May 29, 2024
18 checks passed
@OxO-7 OxO-7 mentioned this pull request Sep 3, 2024
@Nir-Az Nir-Az deleted the gha-macos-14 branch September 30, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants