-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rs-dds-config #13104
Merged
Merged
rs-dds-config #13104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Jul 1, 2024
Nir-Az
reviewed
Jul 1, 2024
tools/dds/dds-config/eth-config.cpp
Outdated
cfg.link_check_timeout = link.timeout; | ||
cfg.link_priority = (uint8_t)link.priority; | ||
|
||
cfg.mtu = 9000; // R/O, but must be sest to this value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Thanks, dont wait for my review, just wrote what popped into my eye :) |
Fixed warning in exceptions.h |
OhadMeir
reviewed
Jul 3, 2024
OhadMeir
reviewed
Jul 3, 2024
OhadMeir
reviewed
Jul 3, 2024
OhadMeir
reviewed
Jul 3, 2024
OhadMeir
reviewed
Jul 3, 2024
OhadMeir
reviewed
Jul 3, 2024
OhadMeir
reviewed
Jul 3, 2024
OhadMeir
reviewed
Jul 3, 2024
OhadMeir
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add command-line utility to get/set eth config:
--golden
, which also shows the diffs between golden and current with-->
This is most of the basic functionality - not everything was tested but most should be ready.
Tracked on [RSDEV-1998]