readme_edits #13220
Merged
readme_edits #13220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Jul 31, 2024
tools/fw-update/readme.md
Outdated
| An example for the expected output is: | ||
|
|
||
| ``` | ||
| update to FW: Signed_Image_UVC_5_11_6_250.bin | ||
| Update to FW: C:\Users\nzini\Downloads\d400_series_fw_5_15_1_0\Signed_Image_UVC_5_15_1_0.bin |
There was a problem hiding this comment.
This return the whole path?
I see nzini :)
There was a problem hiding this comment.
missed it, now it's fixed :)
Nir-Az
reviewed
Jul 31, 2024
tools/fw-update/readme.md
Outdated
|
|
||
| firmware update progress: 100[%] | ||
| Firmware update progress: 0[%] |
There was a problem hiding this comment.
Aren't we expected to finish with 100%?
There was a problem hiding this comment.
It was a bug, looks like the function compute_progress(..) was modified for d500-fw-update-device but the change caused d400-fw-update-devices progress to show 0% throughout the update.
I changed it so it would calculate the progress deferentially depends on the device.
There was a problem hiding this comment.
Great catch
Was this tested both on D400 & D500 devices?
Nir-Az
reviewed
Jul 31, 2024
Nir-Az
approved these changes
Aug 1, 2024
Nir-Az
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked on [RSDEV-2527]