-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ARM NEON intrinsics to unpack_yuy2 #13270
Add ARM NEON intrinsics to unpack_yuy2 #13270
Conversation
Can one of the admins verify this patch? |
I explained too little, my apologies. |
Hi @fateshelled , |
Hi @Nir-Az , |
It will take us some time to review and validate this PR on dedicated HW. |
0e54f81
to
a13850d
Compare
Thanks for the reply. |
{ | ||
// Load 16 pixels | ||
const uint8x8x4_t yuyv = vld4_u8(reinterpret_cast<const uint8_t *>(&src[i * 2])); | ||
// yuyv.val[0] = y0, yuyv.val[1] = u, yuyv.val[2] = y1, yuyv.val[3] = v |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wasn't necessary, so I fixed it.
|
||
void unpack_yuy2_neon_y8(uint8_t * const d[], const uint8_t * s, int n) | ||
{ | ||
unpack_yuy2_neon<RS2_FORMAT_Y8>(d, s, n); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not calling the templated function at the first place instead of adding functions that call it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the code image-avx.cpp as a reference, but is this wrong?
librealsense/src/image-avx.cpp
Line 253 in e1688cc
unpack_yuy2<RS2_FORMAT_Y8>(d, s, n); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not wrong.. just redundant.|
But since our code is a reference let's keep as is
@fateshelled appreciate your contribution, we are always happy to integrate community pull requests :) Thank you :) |
Thank you for merging the PR. |
Changes:
unpack_yuy2_neon
functionyuy2
toy8
,y16
,rgb8
,rgba8
,bgr8
andbgra8
format.