D435i windows IMU support #2788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from Librealsense/Development
Merge from intelrealsense/librealsense/Development
Merge from abernste/librealsense/Development
2. HID HW timestamp in Metadata added 3. use HID_TIMESTAMP_MULTIPLIER for Linux/Windows different timestamp calculations
2. Update Accel/Gyro rates
Merge from Development to windows_hid_support
2. small tweaks
ev-mp
reviewed
Nov 28, 2018
| @@ -176,6 +176,7 @@ namespace librealsense | |||
| // Helper functions for device list manipulation: | |||
| std::vector<platform::uvc_device_info> filter_by_product(const std::vector<platform::uvc_device_info>& devices, const std::set<uint16_t>& pid_list); | |||
| std::vector<std::pair<std::vector<platform::uvc_device_info>, std::vector<platform::hid_device_info>>> group_devices_and_hids_by_unique_id( | |||
| std::shared_ptr<context> ctx, | |||
There was a problem hiding this comment.
I thought the serial num can be retrieved and assigned during platform::hid_device_info initialization, so passing ctx could be avoided
There was a problem hiding this comment.
the serial number is indeed retrieved and assigned during platform::hid_device_info in foreach_hid_device function
But we need to compare it to the UVC device serial number, and to retrieve it we need the ctx because foreach_uvc_device
can't retrieve serial number when using MFEnumDeviceSources
ev-mp
reviewed
Nov 28, 2018
| {"HID Sensor Class Device: Gyroscope", { RS2_STREAM_GYRO, 0, 1, 1, 1000, RS2_FORMAT_MOTION_XYZ32F}}, | ||
| {"HID Sensor Class Device: Accelerometer", { RS2_STREAM_ACCEL, 0, 1, 1, 1000, RS2_FORMAT_MOTION_XYZ32F}}, | ||
| {"HID Sensor Class Device: Custom", { RS2_STREAM_ACCEL, 0, 1, 1, 1000, RS2_FORMAT_MOTION_XYZ32F}}}; | ||
| {{ "HID Sensor Class Device: Gyroscope", {RS2_STREAM_GYRO, 0, 1, 1, 200, RS2_FORMAT_MOTION_XYZ32F}}, |
There was a problem hiding this comment.
Is there a way to support MOTION_RAW ? The asymmetry may introduce issues for CI to run tests on Linux vs Win
There was a problem hiding this comment.
decided to remove RAW from linux too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add D435i IMUs (Accelerometer, Gyro) support for windows