Fixed rs-convert crash #3564
Merged
Fixed rs-convert crash #3564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
rs-convert, the loop termination condition is based on the frame number.Sometimes something weird may happen: the frame with lower frame number will arrive after the frames with higher frame numbers, e.g., the frame 991 first, then frame 990. This situation is rare, but it happens, and the loop termination condition may cause the
rs-convertto terminate before converting all the frames, as described in issue #3208 and #1919.Inspired by @UnaNancyOwen in his tool, I changed the termination condition to the playback position, which will not cause early terminations in such situation.