Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix T265 Pose attributes in record/playback scenarios #3884

Merged
merged 10 commits into from
May 5, 2019
Merged

Fix T265 Pose attributes in record/playback scenarios #3884

merged 10 commits into from
May 5, 2019

Conversation

ev-mp
Copy link
Collaborator

@ev-mp ev-mp commented May 2, 2019

  • Fix Pose record/playback flow to provide frame metadata - ts, fps, f.num
  • Record and provide T265 Pose stream extrinsic parameters.
  • Add rs-enumerate-devices functionality to parse playback device's info

rs-enumerate-devices -f realsense_device_record.bag

  • Fix the playback device context persistence, as requested by ctx.load_device API.

Derived on analysis of #3837
Tracked On: TM2-4344

ev-mp added 9 commits May 2, 2019 15:25
@ev-mp
T265 pose attributes fix in recorder
a485feb 
Recorder fixes
@ev-mp
Expose pose_stream_profile class.
6daf03b 
rs-enumerate-devices to provide Pose stream extrinsic

Change-Id: Ic3b7e083f0b55ea5909040479c72990f53dad982
@ev-mp
Fix T265 extrinsic registration.
739bb13 
Required for the ROSBag recorder

Change-Id: I8d3f75693bf5d13df9353e2a1acb92e25f151c63
@ev-mp
Workaround for matlab build with CMAKE_DEBUG_SUFFIX
224e7e1 
Change-Id: I08109c0b3dcfc25bd4ff6c647fbf21b985a52169
@ev-mp
Fix GCC 7.4 Warinings
3dad95d
@ev-mp
rs-enumerate-devices utility shall be able to parse playback (record)…
567aaf5 
… devices
@ev-mp
Fix playback shared device handle so that the object will actually be…
c78710b 
… stored in the context object

Fix ROS record/playback with regards to the Pose sensor/frames.
Verify extrinsic/intrinsic retrieval for T265 ROS playback
Enabling pose profile to be properly enumerated rs-enumerate
Enable rs-enumerate-devices to list all the sensor/device features from ROS record (playback device)

Change-Id: Ic952c5e78bf7ded6a6eaccb3b6179f3046161a4f
@ev-mp
Revert playback_device to be weak_ptr reference to prevent circular lock
877722a 
Change-Id: I2969eca0b3784100f6e751c615cd15690e4be6e2
@ev-mp
Reenable contex playback device persistency
5279299 
Change-Id: I4c2aa3c91f9fa192b12300daeb64fe0cce6e4189
@ev-mp ev-mp requested a review from dorodnic May 5, 2019 06:45
@ev-mp ev-mp merged commit 5d50993 into IntelRealSense:development May 5, 2019
@ev-mp ev-mp deleted the 3837 branch May 7, 2019 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorodnic dorodnic Awaiting requested review from dorodnic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ev-mp