Merge of 'rc2' branch #6487
Merged
Merge of 'rc2' branch #6487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Propagate 0x0b64 PID to MD patch
…infrared images are received as well.
Fixed bug RS5-7628
Adresses RS5-7715
Release frame resource in PB callback if not required.
Build + syncer mem leak fixes
# Conflicts: # src/frame-validator.cpp
ev-mp
reviewed
Jun 1, 2020
| @@ -2,10 +2,6 @@ | |||
|
|
|||
| ----------------- | |||
|
|
|||
There was a problem hiding this comment.
Shouldn't it be left in place?
There was a problem hiding this comment.
@dorodnic Can you comment? Should this stay in, or be removed?
There was a problem hiding this comment.
I don't see the value. When it was multiple systems it made sense. Today its just Travis, and we check before merging
If Gated passed but Push build failed, what would you do with it?
dorodnic
approved these changes
Jun 1, 2020
| @@ -2,10 +2,6 @@ | |||
|
|
|||
| ----------------- | |||
|
|
|||
There was a problem hiding this comment.
I don't see the value. When it was multiple systems it made sense. Today its just Travis, and we check before merging
If Gated passed but Push build failed, what would you do with it?
|
@maloel , please update the PR content and RS5-xxxx references. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.