-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge of 'rc2' branch #6487
Merge of 'rc2' branch #6487
Conversation
Propagate 0x0b64 PID to MD patch
…infrared images are received as well.
Fixed bug RS5-7628
Adresses RS5-7715
Release frame resource in PB callback if not required.
Build + syncer mem leak fixes
# Conflicts: # src/frame-validator.cpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just check the comment - I'm not sure it should be removed
@@ -2,10 +2,6 @@ | |||
|
|||
----------------- | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be left in place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dorodnic Can you comment? Should this stay in, or be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the value. When it was multiple systems it made sense. Today its just Travis, and we check before merging
If Gated passed but Push build failed, what would you do with it?
@@ -2,10 +2,6 @@ | |||
|
|||
----------------- | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the value. When it was multiple systems it made sense. Today its just Travis, and we check before merging
If Gated passed but Push build failed, what would you do with it?
@maloel , please update the PR content and RS5-xxxx references. |
No description provided.