Viewer starts without Documents directory #6567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ev-mp
requested changes
Jun 11, 2020
aseelegbaria
changed the title
maloel
requested changes
Jun 16, 2020
There was a problem hiding this comment.
As discussed with Aseel, a solution that automatically creates a Documents folder for the user is problematic and not needed.
What is needed is for the Viewer to not crash or behave badly.
Since the folder is controlled by settings, if it does not exist a log should simply not be written.
Same for recording: the folder is controlled by settings. If the folder does not exist, when the user presses Record then we should query the user for a location through the regular means (which should already exist).
maloel
reviewed
Jul 26, 2020
common/os.cpp
Outdated
| else if ( f == user_documents) | ||
| { | ||
| std::string msg = "Failed to get Documents directory"; | ||
| rs2::log(RS2_LOG_SEVERITY_INFO, msg.c_str()); |
maloel
reviewed
Jul 26, 2020
maloel
approved these changes
Jul 27, 2020
ev-mp
requested changes
Jul 27, 2020
common/os.cpp
Outdated
| @@ -287,6 +287,11 @@ Some auxillary functionalities might be affected. Please report this message if | |||
| res = str; | |||
| res += "\\"; | |||
| } | |||
| else if ( f == user_documents) | |||
| { | |||
| std::string msg = "Failed to get Documents directory"; | |||
There was a problem hiding this comment.
Pls parse and print the value of HRESULT hr = SHGetKnownFolderPath(... - there are additional failure cases as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5707
Tracked on: DSO-13589