Fix ctrl+Num keys not rendering on viewer terminal #7133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maloel
approved these changes
Aug 21, 2020
Nir-Az
deleted the
Fix_ctrl+num_keys_doesnt_render_on_viewer_input_text
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Viewer application does not support special keys like '_' (all of shift + Num keys) as inputs
The code that was removed on this PR is the reason.
It was inserted as part of the terminal feature to allow copy-paste capabillity.
When removing it I tested in windows + Linux that the copy-paste capability still works.
and now so does the special keys