Udev rules power down #7635
Merged
Udev rules power down #7635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ev-mp
reviewed
Oct 27, 2020
scripts/setup_udev_rules.sh
Outdated
| fi | ||
| sudo cp config/99-realsense-libusb.rules /etc/udev/rules.d/ | ||
| echo | sudo tee -a /etc/udev/rules.d/99-realsense-libusb.rules > /dev/null | ||
| echo "KERNEL==\"iio*\", ATTRS{idVendor}==\"8086\", ATTRS{idProduct}==\"0ad5|0afe|0aff|0b00|0b01|0b3a|0b3d|0b64\", RUN+=\"/bin/sh -c '(major=\`uname -r | cut -d \\\".\\\" -f1\` && minor=\`uname -r | cut -d \\\".\\\" -f2\` && (([ \\\$major -eq 4 ] && [ \\\$minor -ge 15 ]) || [ \\\$major -ge 5 ])) && enfile=/sys/%p/buffer/enable && echo \\\"COUNTER=0; while [ \\\$COUNTER -lt 20 ] && grep -q 0 \$enfile; do sleep 0.01; COUNTER=\\\$((COUNTER+1)); done && echo 0 > \$enfile\\\" | at now'\"" | sudo tee -a /etc/udev/rules.d/99-realsense-libusb.rules > /dev/null |
There was a problem hiding this comment.
Pls add in-place description for what is doing on for maintainers.
One more thing - currently it will run for both Accel and Gyro, but we know that the issue occurs with Accel.
so even if accelerometer will be fixed immediately we'll still wait for 200 msec for gyro ( that won't start)
Can the condition "KERNEL=="iio*", ATTRS{idVendor}=="8086" be further fine-tuned?
scripts/setup_udev_rules.sh
Outdated
| # --uninstall : remove permissions for realsense devices. | ||
|
|
||
| install=true | ||
| auto_power_off=false |
There was a problem hiding this comment.
Where is this set to true? I though it is a command line flag
scripts/setup_udev_rules.sh
Outdated
| fi | ||
| sudo cp config/99-realsense-libusb.rules /etc/udev/rules.d/ | ||
| echo | sudo tee -a /etc/udev/rules.d/99-realsense-libusb.rules > /dev/null | ||
| echo "KERNEL==\"iio*\", ATTRS{idVendor}==\"8086\", ATTRS{idProduct}==\"0ad5|0afe|0aff|0b00|0b01|0b3a|0b3d|0b64\", RUN+=\"/bin/sh -c '(major=\`uname -r | cut -d \\\".\\\" -f1\` && minor=\`uname -r | cut -d \\\".\\\" -f2\` && (([ \\\$major -eq 4 ] && [ \\\$minor -ge 15 ]) || [ \\\$major -ge 5 ])) && enfile=/sys/%p/buffer/enable && echo \\\"COUNTER=0; while [ \\\$COUNTER -lt 20 ] && grep -q 0 \$enfile; do sleep 0.01; COUNTER=\\\$((COUNTER+1)); done && echo 0 > \$enfile\\\" | at now'\"" | sudo tee -a /etc/udev/rules.d/99-realsense-libusb.rules > /dev/null |
There was a problem hiding this comment.
The code segment need to be refactored into the udev-rules so it will be also picked up when the udev-rules are installed not by this script, such as in case with Debian or manual install
--uninstall : remove permissions for realsense devices. --auto_power_off : add script for automatic power off. Remove auto power off from config/99-realsense-libusb.rules
…t to 0. No hard code sleeping time. remove power-down line from config/99-realsense-libusb.rules scripts/setup_udev_rules.sh sets the power-down line to 99-realsense-libusb.rules file.
…sense-libusb.rules increase timeout to 200mSec based on a NUC test. Modify rule to apply for accel sensor only.
doronhi
force-pushed
the
udev_rules_power_down
branch
from
ad95948
to
a22be02
Compare
Done. |
ev-mp
reviewed
Nov 1, 2020
Test check if power is down for a newly connected device and after resetting it. It also check that while the first camera is running, connecting a second camera wont interfere. A flag '--help' prints a usage message.
Add timeout of 10 seconds for device to be connected.
ev-mp
reviewed
Nov 3, 2020
| @@ -57,6 +57,8 @@ The scripts and commands below invoke `wget, git, add-apt-repository` which may | |||
| 3. Run Intel Realsense permissions script from librealsense root directory:<br /> | |||
| `./scripts/setup_udev_rules.sh` | |||
| <br /> | |||
| *Notice: One can always remove permissions by running:* | |||
| *`./scripts/setup_udev_rules.sh --uninstall`* | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On kernel 5.x.x.x there is an issue with iio sensors - some of them does not reduce power consumption after connection.
This udev-rules correction disables the sensor after it's initial connection.
Related to DSO-15863