-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace GVD queries with device update notification to verify device removal during DFU #8913
Conversation
How come it's only one commit? Why don't I see a revert followed by your changes? |
src/context.h
Outdated
@@ -43,7 +43,7 @@ namespace librealsense | |||
class device_info | |||
{ | |||
public: | |||
virtual std::shared_ptr<device_interface> create_device(bool register_device_notifications = false) const | |||
virtual std::shared_ptr<device_interface> create_device(bool register_device_notifications = true) const |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we checked that we always use the default arg?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This parameter was removed, create device will always create it with a callback.
Verified playback work as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
network device does not inherent device so it's good too.
@@ -256,7 +256,7 @@ namespace librealsense | |||
} | |||
} | |||
|
|||
return ctx->add_device(file)->create_device(false); | |||
return ctx->add_device(file)->create_device(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So playback device will get notifications now? Can it even be "removed"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, playback device override the create_device() function and is not calling the function we change it's defaults.
So it's OK, nothing changed there.
We add a ~6 seconds maximum loop to verify the device is disconnected after the DFU command (replacing HWM calls)
This partly reverts PR #8018 which caused freezes after DFUs.
Tracked on [RS5-11058]