-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/doc-jetson-installation #9633
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tkazik , thank you for the contribution.
Can you restructure the PR so that the editorial and content changes will be captured in separate commits for review?
Thanks
Besides the fix, 99% of the changes in this PR consists of editorial changes in order to satisfy the markup rules...the diff looks like as if there are many content changes, but this is not the case. You can verify that using the markdown preview in e.g. VS Code. |
Well, so please just extract the fix into a separate commit for review. |
This reverts commit 18db4a8.
alright, so it is now split into 'fix' and 'editorial' changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tkazik , thank you for the quick response.
While I think the fix commit is ok the "editorial" change seem to break the layout and exposes the MD syntax, at least in chap#4 and below. See example
The first part seem ok,, so if you can refactor it into a separate PR it will be merged promptly.
Thanks
doc/installation_jetson.md
Outdated
|
||
2. **Establish Developer's Environment** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is a header. Put double-space or /n
to separate from the para below
hm, what exactly is jenkins complaining about? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tkazik , thank you for contribution!
This PR fixes the installation for jetson, which is currently broken for the second part. It also has some minor editorial changes to enhance readability.