Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android fix dso 14436 [Android] RS Camera viewer restarts the stream when rotating screen. #9662

Merged
merged 5 commits into from
Sep 5, 2021

Conversation

gwen2018
Copy link
Contributor

Changes:

  • Handle device orientation change to avoid interruption during preview, recording and playback
  • Fix memory leak during device rotations

Tracked on: DSO-14436

@gwen2018 gwen2018 changed the title Android fix dso 14436 Android fix dso 14436 [Android] RS Camera viewer restarts the stream when rotating screen. Aug 20, 2021
@ev-mp ev-mp requested a review from remibettan August 24, 2021 10:35
Copy link
Contributor

@remibettan remibettan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm you have tried it and stream does not stop when changing orientation (in Preview, Record and Playback.
Please change the method name setup_controls to setupControls.

@gwen2018
Copy link
Contributor Author

@remibettan yes, checked in debugger/logcat and other means, stream does not stop during orientation change. in preview, the stream duration timestamp shows it continuous. in recording, a single file is generated instead of multiple since there is no session stop/restart. similarly, in plackback, it's also continuous. method rename done.

Copy link
Contributor

@remibettan remibettan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ev-mp ev-mp merged commit bcebb9b into IntelRealSense:development Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants