Replace deprecated LZ4 function calls #9758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maloel
reviewed
Sep 13, 2021
|
|
||
| #pragma once | ||
|
|
||
| // This function calculates and returns the zero padded amount of bytes added to the last index of the uint32_t vector (32 bit alignment) |
maloel
reviewed
Sep 13, 2021
| @@ -1,14 +1,18 @@ | |||
| // License: Apache 2.0. See LICENSE file in root directory. | |||
| // Copyright(c) 2018 Intel Corporation. All Rights Reserved. | |||
|
|
|||
| // This file is auto-generated from d415.obj | |||
| // This file is auto-generated from d415.obj using rs-embed tool | |||
| // Manual changes added to support upgrade of LZ4 3-rd party deprecated function) | |||
There was a problem hiding this comment.
I think we should change rs-embed to output these manual changes.
I think we should automatically run rs-embed and generate these files if realsense2-gl is compiled.
There was a problem hiding this comment.
And I think these do not belong in common/res... but rather in realsense2-gl?
|
Closed and continued on PR #9764 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracked on [LRS-290]