-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UCAL inconsistencies #9912
Fix UCAL inconsistencies #9912
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one comment there - please check it.
Great code!
@@ -901,6 +903,7 @@ namespace rs2 | |||
{ | |||
try | |||
{ | |||
std::this_thread::sleep_for(std::chrono::milliseconds(1000)); // W/A that allows for USB2 exposure to settle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please confirm that there is no other way to solve this (like some trigger from the exposure control)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other way is to generate a mechanism that will ensure the camera's exposure is stabilized. But since we can't know it from metadata (the exposure value reported is always the same, but the picture itself is changing), it must be done using Computer Vision methods, which is quite complicated.
In the tests, having 500 msec delay was sufficient to make the algorithm converge in more than 90% of cases. So making it 1000 is has some spair time to make sure it will also run smoothly in low-end platforms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
Fix hyperlink for user notification not opened due to overlapping textbox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Viewer-specific fixes and refinements:
Tracked on : DSO-17819, DSO-17820