Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D405 URDF Description #2589

Closed
vonHartz opened this issue Jan 2, 2023 · 18 comments
Closed

D405 URDF Description #2589

vonHartz opened this issue Jan 2, 2023 · 18 comments
Assignees
Labels

Comments

@vonHartz
Copy link

vonHartz commented Jan 2, 2023

Hi everyone,

following up on #2317, there still seems to be no URDF description for the D405.
When will this be resolved?

Cheers

@MartyG-RealSense
Copy link
Collaborator

Hi @vonHartz I will raise the issue with the RealSense ROS developer team. Thanks very much for your question!

@MartyG-RealSense
Copy link
Collaborator

MartyG-RealSense commented Jan 3, 2023

Hi @vonHartz The RealSense ROS developer team has advised me that the addition of a URDF for D405 is planned for a future wrapper release.

@vonHartz
Copy link
Author

vonHartz commented Jan 3, 2023

Thanks for your reply @MartyG-RealSense
Do you have an estimated release date?

@MartyG-RealSense
Copy link
Collaborator

I do not have a time estimate for implementation at the time of writing this, unfortunately.

@MartyG-RealSense
Copy link
Collaborator

As URDF for D405 is planned for a future release, I have added an Enhancement tag to this issue so that it is kept open.

@chavasse
Copy link

chavasse commented Mar 7, 2023

+1 for this

@weaponeer
Copy link

As well, ++

@SamerKhshiboun
Copy link
Contributor

SamerKhshiboun commented Apr 11, 2023

Hi @chavasse, @weaponeer, @vonHartz,
While we are working to add D405 URDF,
If you can work with dae / step / stl files, this is a good workaround for you:
You can download the cad file of D405 from here

Then you can convert this STEP file to dae and stl files
(I managed to download FreeCAD, and convert (File -> Export) these STEP file to .stl and .dae files)

You can import this dae file into your urdf.
For example:

<link name="my_link">
  <visual>
    <origin xyz="0 0 0" rpy="0 0 0"/>
    <geometry>
      <mesh filename="path/to/my_file.dae"/>
    </geometry>
  </visual>
</link>

@MartyG-RealSense
Copy link
Collaborator

MartyG-RealSense commented Apr 23, 2023

Hi @chavasse @weaponeer and @vonHartz Was the information in the above comment helpful to you, please? Thanks!

@chavasse
Copy link

Hi @MartyG-RealSense not really, sorry!
The information needed is stored in the URDF model with the links and offsets between the mechanical fastening point(s) and camera frames to get accurate positioning. It's all information that is in the datasheet so we can work around it, but it's a bit clunky and should really be handled/published by this package.
Thanks

@MartyG-RealSense
Copy link
Collaborator

Hi @chavasse No problem, thanks very much for your feedback!

@weaponeer
Copy link

Thanks for the suggestion, but same here -- as chavasse mentioned.

@SuperN1ck
Copy link

Hey,
just a friendly ping. Are there any updates when this is planned to be released? This would be super helpful to have!
Cheers,
-Nick

@MartyG-RealSense
Copy link
Collaborator

MartyG-RealSense commented Dec 1, 2023

Hi @SuperN1ck Thanks very much for your query about a URDF for the D405. I have highlighted your question to my colleagues on the RealSense ROS team.

@MartyG-RealSense
Copy link
Collaborator

Hi @SuperN1ck The RealSense ROS team will take a look at the feature request for a D405 URDF to see what action to next take about it.

@Arun-Prasad-V
Copy link
Contributor

Hi @vonHartz, @chavasse, @weaponeer, @SuperN1ck,
A reference D405 URDF description is now available in ros2-development branch. Please refer the PR #2953.

Would really appreciate if you guys can try it out and let us know your feedback.
ros2 launch realsense2_camera rs_d405_pointcloud_launch.py

Thanks!

@MartyG-RealSense
Copy link
Collaborator

Hi everyone, have you been able to test the new URDF for the D405 camera model that is now available, please - see #2589 (comment)

@MartyG-RealSense
Copy link
Collaborator

Case closed due to D405 URDF having been implemented and no further comments received.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants