Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copyright and license to all ROS2-beta source files #2302

Merged
merged 5 commits into from
Apr 3, 2022

Conversation

SamerKhshiboun
Copy link
Collaborator

@SamerKhshiboun SamerKhshiboun commented Mar 29, 2022

  • Added pr_check.sh script which checks Intel copyrights, Apache license, line endings and tabs in for all source files of all folders
  • Updated main.yml steps order to first run pr_check script before running any build actions

Tracked by LRS-399

@SamerKhshiboun SamerKhshiboun marked this pull request as ready for review March 29, 2022 08:29
scripts/pr_check.sh Outdated Show resolved Hide resolved
scripts/pr_check.sh Outdated Show resolved Hide resolved
scripts/pr_check.sh Outdated Show resolved Hide resolved
- added documentation
- fixed this scripts tabs/line-endings
@@ -89,4 +95,5 @@ jobs:
cd ${{github.workspace}}/ros2
source ${{github.workspace}}/.bashrc
. install/local_setup.bash
python3 src/realsense-ros/realsense2_camera/scripts/rs2_test.py non_existent_file
python3 src/realsense-ros/realsense2_camera/scripts/rs2_test.py non_existent_file

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add ending line

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, I added a one, but still getting this icon/warning here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe because it has spaces in it.

@maloel maloel merged commit bfcafbe into IntelRealSense:ros2-beta Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants